-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Qwen FP8 ModelOPT support #20734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qwen FP8 ModelOPT support #20734
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jingyu-ml, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands vLLM's quantization capabilities by integrating full support for ModelOPT FP8 quantized models, with a particular focus on Qwen models. It introduces new quantization methods for linear and Mixture-of-Experts (MoE) layers, refines the weight loading process to accommodate ModelOPT's specific checkpoint formats and scale handling, and includes model-specific adaptations to ensure seamless loading and execution of these quantized models. The changes aim to broaden the range of supported models and improve loading efficiency for quantized architectures.
Highlights
- ModelOPT FP8 Quantization Support: Added comprehensive support for ModelOPT FP8 quantization, enabling vLLM to load and run models quantized with this method. This includes identifying ModelOPT FP8 from Hugging Face configurations and handling its specific data formats.
- Mixture-of-Experts (MoE) Layer Quantization: Introduced
ModelOptFp8MoEMethod
to specifically handle FP8 quantization for MoE layers. This new method manages the creation of FP8 weights and scales, processes scales after loading (e.g., combining w1 and w3 scales), and applies the quantization during the forward pass. - Flexible Weight Loading Enhancements: Improved the weight loading mechanism across various models to dynamically adapt to different ModelOPT weight scale patterns (e.g.,
weight_scale
vs.weight_scale_2
) and to correctly handle complex expert scale broadcasting from single values to multiple experts. This includes updates tollama4
,mllama4
,qwen2
, andqwen3_moe
. - Performance Optimizations for MoE: Introduced
supports_moe_loading
flags to relevant weight loaders (FusedMoE
,experts_int8
,moe_wna16
) to explicitly mark them as MoE-aware. This optimization helps avoid expensive runtime reflection during model loading, improving efficiency for MoE architectures. - KV Cache Scale Remapping: Enhanced the
maybe_remap_kv_scale_name
utility to correctly remap KV cache scale names, including support forqkv_proj
parameters, ensuring accurate loading of attention-related scales in quantized models.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Qwen models with FP8 quantization using ModelOPT. The changes span several files, including configuration, model layers, and weight loading utilities. Key additions include logic to parse ModelOPT-specific quantization configurations and a new ModelOptFp8MoEMethod
for handling MoE layers. Overall, the changes are well-structured to support the new quantization format.
This pull request has merge conflicts that must be resolved before it can be |
8afa3fa
to
1bf1f84
Compare
1bf1f84
to
ca9e2be
Compare
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Add the QwQ-32B/Qwen2.5/Qwen3/Qwen3-MoE FP8 support from ModelOPT.
The FP8 ckpt can be generated using ModelOPT's example: https://github.com/NVIDIA/TensorRT-Model-Optimizer/tree/main/examples/llm_ptq.
Tested on QwQ-32B/Qwen2.5-14B/Qwen3-1.7B/Qwen3-30B-A3B
Test Plan
Using this script to test it:
Test Result
(Optional) Documentation Update